Fix test_targetsmart_smartmatch on windows + code coverage improvement #1271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmos
force-pushed
the
windows-test
branch
3 times, most recently
from
83b02bc to
3f04c1d
Compare
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
bmos
changed the title
bmos
force-pushed
the
windows-test
branch
4 times, most recently
from
6fdf11c to
bdcfb06
Compare
shaunagm
approved these changes
Mar 11, 2025
Collaborator
shaunagm
left a comment
shaunagm
left a comment
There was a problem hiding this comment.
This looks good to me, although I don't use smartmatch and so I don't trust the thoroughness of my review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1124 by re-enabling smartmatch test on Windows (and fixing smartmatch to work on Windows as well).